On Mon, Aug 29, 2011 at 5:38 AM, Antoine Jacoutot <ajacou...@bsdfrog.org> wrote:
> On Mon, 29 Aug 2011, Brad wrote:
>> On 29/08/11 6:29 AM, Antoine Jacoutot wrote:
>> > On Mon, 29 Aug 2011, Brad wrote:
>> >
>> > > On 29/08/11 6:10 AM, Antoine Jacoutot wrote:
>> > > > On Mon, 29 Aug 2011, Abel Abraham Camarillo Ojeda wrote:
>> > > >
>> > > > > Antoine Jacoutot<ajacou...@bsdfrog.org> wrote:
>> > > > >
>> > > > > > You shouldn't hardcode '/etc' but use ${SYSCONFDIR} instead.
>> > > > > >
>> > > > > >
>> > > > > > --
>> > > > > > Antoine
>> > > > > >
>> > > > >
>> > > > > I'm sure I was missing something...
>> > > > >
>> > > > > Reroll diff:
>> > > >
>> > > > Can't the port just use CONFIGURE_STYLE=gnu so that
>> > > > --sysconfdir=${SYSCONFDIR} is passed to configure?
>> > >
>> > > Not when there isn't any necessity to do so. The second diff is fine.
>> >
>> > Care to explain? Why patching when setting a variable is enough.
>> > Please extend.
>>
>> Yes. dragging in the alternative build system and thus autoconf
>> vs adding the one extra line to the Makefile is ridiculous. Why
>> add a whole run of autoconf to set ONE variable in a Makefile?
>
> Then why not use sysconfdir=${SYSCONFDIR} in MAKE_ENV or FLAGS instead
> of patching?
>
> --
> Antoine
>
There is already SYSCONFDIR=${SYSCONFDIR}, let me try it lowercased...
