Antoine Jacoutot <ajacou...@bsdfrog.org> wrote:

> On Mon, 29 Aug 2011, Brad wrote:
> > On 29/08/11 6:29 AM, Antoine Jacoutot wrote:
> > > On Mon, 29 Aug 2011, Brad wrote:
> > > 
> > > > On 29/08/11 6:10 AM, Antoine Jacoutot wrote:
> > > > > On Mon, 29 Aug 2011, Abel Abraham Camarillo Ojeda wrote:
> > > > > 
> > > > > > Antoine Jacoutot<ajacou...@bsdfrog.org>   wrote:
> > > > > > 
> > > > > > > You shouldn't hardcode '/etc' but use ${SYSCONFDIR} instead.
> > > > > > > 
> > > > > > > 
> > > > > > > --
> > > > > > > Antoine
> > > > > > > 
> > > > > > 
> > > > > > I'm sure I was missing something...
> > > > > > 
> > > > > > Reroll diff:
> > > > > 
> > > > > Can't the port just use CONFIGURE_STYLE=gnu so that
> > > > > --sysconfdir=${SYSCONFDIR} is passed to configure?
> > > > 
> > > > Not when there isn't any necessity to do so. The second diff is fine.
> > > 
> > > Care to explain? Why patching when setting a variable is enough.
> > > Please extend.
> > 
> > Yes. dragging in the alternative build system and thus autoconf
> > vs adding the one extra line to the Makefile is ridiculous. Why
> > add a whole run of autoconf to set ONE variable in a Makefile?
>
> Then why not use sysconfdir=${SYSCONFDIR} in MAKE_ENV or FLAGS instead 
> of patching?
>
> -- 
> Antoine

According to grep -R SYSCONFDIR, SYSCONFDIR is used nowhere, this works
and is tested on amd64.

Or should we patch all references of lowercase sysconfdir to uppercase
them? :P

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/git/Makefile,v
retrieving revision 1.80
diff -u -r1.80 Makefile
--- Makefile    30 Jul 2011 05:08:05 -0000      1.80
+++ Makefile    29 Aug 2011 16:49:33 -0000
@@ -11,7 +11,7 @@
 PKGNAME-x11 =  git-x11-${V}
 CATEGORIES =   devel

-REVISION =     0
+REVISION =     1

 HOMEPAGE =     http://git-scm.com/

@@ -67,7 +67,7 @@
 PKG_ARCH-x11 =         *

 MAKE_ENV =             prefix=${PREFIX} CC="${CC}" CFLAGS="${CFLAGS}" V=1 \
-                       SYSCONFDIR=${SYSCONFDIR} \
+                       sysconfdir=${SYSCONFDIR} \
                        TCLTK_PATH=${MODTK_BIN} \
                        TCL_PATH=${MODTCL_BIN} \
                        REGRESS_SHELL=${LOCALBASE}/bin/bash

--
DISCLAIMER: http://goldmark.org/jeff/stupid-disclaimers/ 
This message will self-destruct in 3 seconds.

Reply via email to