On 2013/01/10 13:41, Stefan Sperling wrote:
> A port of MegaGlest ist attached. It requires the libircclient
> port which I just sent separately.
> So this game will only work with specific hardware.
This is the same for various other games and video-related packages;
it should certainly be linked to the build to make sure that it gets
picked up in bulk builds so that changes to other ports affecting this
get build-tested. Regarding space on mirrors, 270MB * 2 arch * (2
releases + 1 snapshot) = 1.6GB, required space is currently around
375GB so there's plenty of space on the smallest disk which will
fit an OpenBSD mirror (500GB), so I don't think that's a major
problem.
> I've split the port into two packages, one package for the game
> itself, and a much larger package (about 270MB) for game data.
The split makes sense; no need to download the data if updating the
main program for a library bump etc.
a few comments on the port,
- subdir Makefile: use the standard layout i.e. start with "SUBDIR ="
on its own and then use += on additional lines.
- data/Makefile: just set DISTNAME, no point setting DISTFILES.
it also wants PKG_ARCH=* and probably NO_REGRESS=Yes (or maybe NO_REGRESS
should go in Makefile.inc though, haven't checked)
- base/Makefile: rather than overriding DISTFILES, set
DISTNAME=megaglest-source-${V} PKGNAME=megaglest-${V}.
zap MODLUA_VERSION=5.1, it's the default anyway; if anyone is
thinking of switching in future it will be easier to just switch
in lua.port.mk and do a bulk to see what breaks rather than
look for hardcoded versions in ports using the module.
- base/pkg/PLIST: regenerate plist, share/applications/ will be
stripped as it's provided by desktop-file-utils.
- nitpicking, I would add the trailing / to HOMEPAGE (it is always
going to have to do an http redirect otherwise), and add a blank
line after the rcs id line.
