On Tue, Sep 24, 2013 at 06:37:31PM -0400, Ido Admon wrote:
> It was a peachy Monday, Sep 23 2013, 21:24:43, when Landry Breuil wrote:
> 
> > On Tue, Sep 24, 2013 at 04:59:34PM -0400, Ido Admon wrote:
> > > 
> > > It was a peachy Monday, Sep 23 2013, 21:08:15, when Landry Breuil
> > > wrote:
> > > 
> > > > On Mon, Sep 23, 2013 at 04:40:29PM -0400, Ido Admon wrote:
> > > >> fixes a crash with gnutls for me.
> > > >> also, they're packing all the plugins now, so
> > > >> mail/{claws-mail-attremover,claws-mail-htmlviewer,claws-mail-notification,
> > > >> claws-mail-rssyl,claws-mail-vcalendar}
> > > >> can be get rid of.
> > > >
> > > > Nice, but that will require some @pkgpath/@eicts to handle
> > > > migrations.
> > > 
> > > done. new diff attached.
> > 
> > Missing @pkgpath for the moved plugins, @conflict is not enough, you
> > also need @pkgpath mail/claws-mail-attremover
> > @pkgpath mail/claws-mail-notification
> > @pkgpath mail/claws-mail-rssyl
> > @pkgpath mail/claws-mail-vcalendar
> 
> right, ok.
>  
> > > > Also, why are you disabling notification and pdfviewer plugins ?
> > > 
> > > i think i had some trouble getting them to compile and didn't want
> > > them to get in the way of progress, but now they seem to work just
> > > fine, so must have been something local.
> > > 
> > > > As i understand it, the 'fancy' plugin supersedes the gtkhtml2
> > > > viewer plugin that disappeared from upstream ?
> > > > http://www.claws-mail.org/plugin.php?plugin=gtkhtml2 isnt listed
> > > > anymore on http://www.claws-mail.org/plugins.php
> > > 
> > > yup. with webkit (which is weighty, so it's in a subpackage).
> > 
> > Makes sense to subpackage it, but for -pdfviewer i think it can be
> > bundled in -main. Who uses a MUA without a bundled pdf reader those
> > days ? ppl still like to use an external app ? Claws alreadu has some
> 
> actually, yes, i do... but i wouldn't really cry too much over it if
> whoever commits this decides to scrap the subpackage.
> 
> > deps, and i dont see poppler as something that huge. Oh well, your
> > call. You can also take MAINTAINERship since it's not claimed atm.
> 
> too much responsibility :)
> 
> > 
> > Note: pkg/PLIST-pdfviewer has an rcs id with PLIST-viewer in it, which
> > looks strange.
> 
> careless substitution. thank you for the patience.

Thanks, commited with a few tweaks, mostly renaming -fancy to
-htmlviewer and used the same PKGNAME for the latter so that upgrades
are transparent from the old one to the new one.

Landry

Reply via email to