On szo, dec 14, 2013 at 22:41:21 +0000, Stuart Henderson wrote: > On 2013/12/14 18:35, LEVAI Daniel wrote: [...] > > | MASTER_SITES = > http://github.com/technion/${PROJECT}/archive/v${V}.tar.gz?dummy=/ > > Rather than this url query hack, please use the newer style of github > handling you'll see in other ports e.g. www/tt-rss.
Oh blimey! I would have sweared that I saw this in devel/libgit2 (that pkg was even your example in [1] :) ). > > | SHARED_LIBS += scrypt 1.0 # 1.0 > > Library versioning for OpenBSD ports should start at 0.0. Right. > | @bin lib/libscrypt.so.0 > | lib/libscrypt.so > > Library generation is wrong, there should be > libscrypt.so.<version_from_shared_libs_line> and also either a > static library, or make the port SHARED_ONLY.. I haven't built but > I guess one of these files is a symlink and one is an incorrectly > built library. Okay, I tried to do a better job this time. The source builds a libscrypt.so.0 file, and I couldn't get pkg_create(1) to recognize the lib mentioned in SHARED_LIBS, so I had to mv libscrypt.so.0 -> libscrypt.so.0.0 I've also @comment-ed the symlink to ...so.0 in PLIST. Now the library is correctly prefixed with @lib in the PLIST. [1] http://marc.info/?l=openbsd-ports&m=138588950307176&w=2 -- LÉVAI Dániel PGP key ID = 0x83B63A8F Key fingerprint = DBEC C66B A47A DFA2 792D 650C C69B BE4C 83B6 3A8F
libscrypt.tar.gz
Description: application/tar-gz
