On Thu, Jan 08, 2015 at 03:44:40PM +0000, David Dahlberg wrote: > Attached is a new version, which addresses all (non-controversial) > remarks. As for Linux and OSX, the OpenBSD-specific script is now also > able to edit temporarily decypted passwords in a ramdisk instead of > regular "/tmp".
Empty line in Makefile after $OpenBSD$ keyword. As tree(1) is already run depends, I would stay below with it. Any reason you are changing it to find(1)? @@ -343,8 +343,8 @@ cmd_show() { cmd_find() { [[ -z "$@" ]] && die "Usage: $PROGRAM $COMMAND pass-names..." IFS="," eval 'echo "Search Terms: $*"' - local terms="*$(printf '%s*|*' "$@")" - tree -C -l --noreport -P "${terms%|*}" --prune --matchdirs --ignore-case "$PREFIX" | tail -n +2 | sed 's/\.gpg$//' + local esc_prefix=`echo "$PREFIX" | sed 's#/#\\\/#g'` + find "$PREFIX" -name *$@* | sed -e "s/^$esc_prefix\//\| /" -e 's/\.gpg$//' } cmd_grep() { @@ -352,7 +352,7 @@ cmd_grep() { What do you think about below change? Be aware, didn't tested it with pass(1) --- files/openbsd.sh Thu Jan 8 12:33:37 2015 +++ files/openbsd.sh Thu Jan 8 16:24:39 2015 @@ -6,7 +6,7 @@ local warn=1 [[ $1 == "nowarn" ]] && warn=0 local template="$PROGRAM.XXXXXXXXXXXXX" - if sysctl kern.usermount | grep -q "=1$"; then + if [ "`sysctl -n kern.usermount`" == "1" ]; then SECURE_TMPDIR="$(mktemp -d "${TMPDIR:-/tmp}/$template")" mount -t tmpfs -o -s16M tmpfs "$SECURE_TMPDIR" || die "Error: could not create tmpfs." unmount_tmpdir() { In general, your port reads fine. I'm not sure where would be better place to put completion and other files. As a side note, in OpenBSD ports, examples are usually placed under: ${PREFIX}/share/examples/${PKGNAME} However, not sure is that applicable for this port. I will let othes comment on this. -- best regards q#