Am Donnerstag, den 08.01.2015, 16:33 +0000 schrieb Mikolaj Kucharski: > As tree(1) is already run depends, I would stay below with it. Any > reason you are changing it to find(1)?
Yes. The tree in OpenBSD ports is http://spootnik.org/tree/tree-0.61.tgz by Pierre-Ives Ritschard, the password-store developers depend according to their documentation on tree >= 1.7.0 from Steve Baker <http://mama.indstate.edu/users/ice/tree>, whose feature set it much bigger than the one of the ports version. The ports version is good enough for the base functionality (display a fancy directory tree in ascii-art), but it cannot do stuff like pattern matching. This is the reason, why I did say, that that particular line needs some consideration whether there might be a more satisfying solution. Be it in the upstream or the port. The reason for me to use find(1) is that it is the straight-forward way to display the expected ("good enough") result for "pass find foo". Drawbacks: The format is different: | Password Store | | bar/foo | | baz/foo instead of the original | Password Store | |-- bar | | `-- foo | `-- baz | `-- foo And because of that of course it breaks the regression test "test/t0400-grep.sh". Although, the output format could graphics could be magicked to to resemble the original, I do not think consider it to be worthwhile. > What do you think about below change? Be aware, didn't tested it with > pass(1) > > --- files/openbsd.sh Thu Jan 8 12:33:37 2015 > +++ files/openbsd.sh Thu Jan 8 16:24:39 2015 > @@ -6,7 +6,7 @@ > local warn=1 > [[ $1 == "nowarn" ]] && warn=0 > local template="$PROGRAM.XXXXXXXXXXXXX" > - if sysctl kern.usermount | grep -q "=1$"; then > + if [ "`sysctl -n kern.usermount`" == "1" ]; then > SECURE_TMPDIR="$(mktemp -d "${TMPDIR:-/tmp}/$template")" > mount -t tmpfs -o -s16M tmpfs "$SECURE_TMPDIR" || die > "Error: could not create tmpfs." > unmount_tmpdir() { Surely. And still works of course. > As a side note, in OpenBSD > ports, examples are usually placed under: > ${PREFIX}/share/examples/${PKGNAME} Yes. I noticed (and changed) that aready locally. Also that one can install multiple files/dirs with "{foo,bar,baz}". Scanning other ports, some place more or less the same kinds of files to "doc/$PACKAGE/examples", some place them to "examples/$PACKAGE". As the documentation lists "examples/$PACKAGE", I consider this to be the right place though. -- David Dahlberg Fraunhofer FKIE, Dept. Communication Systems (KOM) | Tel: +49-228-9435-845 Fraunhoferstr. 20, 53343 Wachtberg, Germany | Fax: +49-228-856277
