On Thu, Jan 15, 2015, at 10:55 PM, Vadim Zhukov wrote: > 2015-01-15 11:24 GMT+03:00 Landry Breuil <lan...@rhaalovely.net>: > > On Tue, Jan 13, 2015 at 10:39:32PM +0100, Adam Wolk wrote: > >> Hi ports@, > >> > >> This is my first port so bring in your favourite flame-thrower to the > >> party. > >> > >> This port has a very active upstream which is really open to taking up > >> pull requests. > >> In case you notice any problems with the software itself - feel free to > >> ping me in order > >> to propagate it up to the developers via a single channel. > >> > >> Testing: > >> > >> This port has been tested on a i386 snapshot of (Jan 10) OpenBSD 5.7 > >> using xfce4. > > > > Some comments on the port itself: > > - you should rerun make update-plist to remove share/applications and > > share/icons/hicolor dirs that are already brought by the dependency no > > gtk+2,guic and desktop-file-utils. > > - we usually put the GH_* variables near the top of the makefile. > > - no need to split the WANTLIB line that much, as long as it fits in 72 > > or 80 chars.. > > > > Other than that it looks good to me. > > Being fully agree with Landry's points, I'd ask for the following > tweaks in addition: > > 1. Remove gcc4 from MODULES and MODGCC4_* lines, qt5.port.mk already > takes care of those. > > 2. CONFIGURE_STYLE comes from cmake.port.mk automagically as well. >
Hi zhuk@, Thanks for taking the time to test. I'll address the first 2 issues today right after work and will try to get a good whack on the backtrace from pt. 3. Regarding pt 3: Since you are the qt5 porter I assume it's a port with latest patches? Would you mind providing me the exact port version used for this test? > 3. Crashes or stucks with hidding window when resizing arbitrary (not via > window > manager's hotkeys) on amd64 with CWM. Here is a backtrace after crash > (SIGBUS): > I'm not sure if I'm understanding you correctly. I saw a crash previously when trying to make the window not full screen using the window manager option in the toolbar. Are you doing something similar? I will be trying to reproduce this and can of course run CWM for the test. Any more details on what exactly leads to the crash will most definetly help :) > #0 0x00001d0b7c82240d in WebCore::QNetworkReplyHandler::finish() () > from /usr/local/lib/qt5/libQt5WebKit.so.0.0 > #1 0x00001d0b7c81f820 in > WebCore::QNetworkReplyHandlerCallQueue::flush() [clone .part.79] () > from /usr/local/lib/qt5/libQt5WebKit.so.0.0 > #2 0x00001d0b7c82258a in > WebCore::QNetworkReplyWrapper::emitMetaDataChanged() () from > /usr/local/lib/qt5/libQt5WebKit.so.0.0 > #3 0x00001d0ae69fe2f8 in QMetaObject::activate(QObject*, int, int, > void**) () from /usr/local/lib/qt5/libQt5Core.so.0.0 > #4 0x00001d0ae69fe2f8 in QMetaObject::activate(QObject*, int, int, > void**) () from /usr/local/lib/qt5/libQt5Core.so.0.0 > #5 0x00001d0b64ce5c34 in QNetworkReplyHttpImplPrivate::finished() () > from /usr/local/lib/qt5/libQt5Network.so.0.0 > #6 0x00001d0b64d6c139 in > QNetworkReplyHttpImpl::qt_static_metacall(QObject*, QMetaObject::Call, > int, void**) () from /usr/local/lib/qt5/libQt5Network.so.0.0 > #7 0x00001d0ae69ff48e in QObject::event(QEvent*) () from > /usr/local/lib/qt5/libQt5Core.so.0.0 > #8 0x00001d0af9f6d72c in QApplicationPrivate::notify_helper(QObject*, > QEvent*) () from /usr/local/lib/qt5/libQt5Widgets.so.0.0 > #9 0x00001d0af9f729f0 in QApplication::notify(QObject*, QEvent*) () > from /usr/local/lib/qt5/libQt5Widgets.so.0.0 > #10 0x00001d0ae69d543d in QCoreApplication::notifyInternal(QObject*, > QEvent*) () from /usr/local/lib/qt5/libQt5Core.so.0.0 > #11 0x00001d0ae69d78a7 in > QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) > () from /usr/local/lib/qt5/libQt5Core.so.0.0 > #12 0x00001d0ae6a25b63 in postEventSourceDispatch(_GSource*, int > (*)(void*), void*) () from /usr/local/lib/qt5/libQt5Core.so.0.0 > #13 0x00001d0b35513f4f in g_main_context_dispatch () from > /usr/local/lib/libglib-2.0.so.4200.0 > #14 0x00001d0b35515f9e in g_main_context_iterate () from > /usr/local/lib/libglib-2.0.so.4200.0 > #15 0x00001d0b35516077 in g_main_context_iteration () from > /usr/local/lib/libglib-2.0.so.4200.0 > #16 0x00001d0ae6a257f3 in > QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) > () from /usr/local/lib/qt5/libQt5Core.so.0.0 > #17 0x00001d0ae69d403b in > QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from > /usr/local/lib/qt5/libQt5Core.so.0.0 > #18 0x00001d0ae69dac38 in QCoreApplication::exec() () from > /usr/local/lib/qt5/libQt5Core.so.0.0 > #19 0x00001d08ae15e0e7 in main () > > I'm not sure if (3) is critical because Otter is designed to behave > like Opera, and Opera was used on the whole screen everywhere I've > seen it, thus no resizing used. > Well I don't like the idea of a browser that crashes when you try to move the window around/resize it :( So glad that you reported it. Regards, Adam Wolk
