On Thu, Sep 17, 2015 at 11:44:12PM +0200, Landry Breuil wrote:
> On Sat, Sep 12, 2015 at 09:05:10AM -0700, patrick keshishian wrote:
> > On 9/12/15, Daniel Jakots <vigdis+o...@chown.me> wrote:
> > > On Fri, 11 Sep 2015 16:45:31 -0700, patrick keshishian
> > > <pkesh...@gmail.com> wrote:
> > >
> > >> Does the Makefile look better? I think it is headed toward a more
> > >> correct direction.
> > >
> > > Hi,
> > >
> > > I tried to build it, I had an error, but Patrick quickly sent me a new
> > > Makefile (attached), I could build it without problem then. I imported a
> > > bunch of osm data in a pgsql database to test, I had the same output
> > > that I usually have on Ubuntu so I guess it's good.
> > >
> > > Thanks for the port!
> > >
> > > Cheers,
> > > Daniel
> > 
> > Thanks for your test and report Daniel.
> > 
> > Attached the new tar-ball.
> 
> After actually looking into it...
> 
> - you have a typo in the patch adding without-lua to configure.ac... but
>   since this wasnt a build option provided by upstream, why bother with
> adding it and doing a flavor for this? i mean, lua dependency isnt
> usually big, and since it provides quite some useful features
> (scriptable tag transforming ?) why not enabling it by default ?
> 
> - REVISION should be removed, no need to start at 0
> 
> - devel/gmake doesnt need to got to BDEP, it's usually done with USE_GMAKE=Yes

As for the autohell stuff, please use MODGNU_AUTOMAKE_DEPENDS &
MODGNU_AUTOCONF_DEPENDS as everywhere else.

Landry

Reply via email to