On Fri, Nov 23 2018, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote:
> On Fri, Oct 19 2018, Solene Rapenne <sol...@perso.pw> wrote:
>> Tom Murphy <open...@pertho.net> wrote:
>>> On Thu, Oct 04, 2018 at 12:11:01PM +0200, Solene Rapenne wrote:
>>> > Small introduction for people reading ports@.
>>> > 
>>> > mvdsv is a quake world game server. It has some features like allowing to
>>> > record games from every player point of view. That can be played again in 
>>> > a
>>> > quake client like ezquake.
>>> > 
>>> > ok solene@
>>> 
>>> Thanks Solene and Stuart for their help! Attached is a new tarball using
>>> GH_TAGNAME and the correct DISTFILES settings.
>>> 
>>> -Tom
>>
>> up
>>
>> looks fine to me
>
> The build system is not very portable. The configure script hardcodes
> a bunch of arch-dependent logic which breaks on eg. sparc64:
>
>   ../../src/pr_exec.c:1: error: -m32 is not supported by this configuration
>
> Also, Makefile.BSD contains:
>
> --8<--
> . if ${MACHINE_ARCH} == "i386" && !defined(WITHOUT_X86_ASM)
>  USE_ASM=-Did386
>  DO_CFLAGS               +=      ${USE_ASM}
>  . endif
> -->8--
>
> It would be good to check that the port builds on i386 with assembly
> enabled.  Or you could wait for bulk build reports.  ;)
>
> Using devel/meson could be a nicer alternative to Makefile.BSD, which
> looks a bit outdated (no curl support for example).

Using meson is cleaner since meson.build doesn't hardcode so much crap.
Also it autodetects system pcre instead of falling back to an ancient
bundled version.  Updated tarball.

Attachment: mvdsv.4.tgz
Description: Binary data

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to