On Fri, Sep 14, 2018 at 02:59:49PM +0100, Stuart Henderson wrote: > On 2018/09/14 15:10, Frederic Cambus wrote: > > Fetching non versioned files like this one is problematic in case the > > content change at some point, so should be avoided. > > > > I don't have a definitive answer on what should be done to move > > this port forward, but I see three options: > > > > 1) Don't fetch and install the .dat file. I see in pkg/README that some > > additional files are required to be manually installed anyway, so it > > could be mentioned here. That's what the FreeBSD port is doing. > > > > 2) Create a versioned archive like qwprogs-20180914.tar.gz containing > > the .dat file and licensing information, and host it somewhere. > > > > 3) Get the .dat file from the Quake repository, using a MASTER_SITES0 > > directive, look at emulators/ppsspp for an example. It's a bit wasteful > > to fetch the whole repository just for one file, but it isn't that big > > so that could be option and this solves the versioning problem. > > You don't need the entire repo, you can fetch the blob by commit id - > https://github.com/id-Software/Quake/raw/0023db327bc1db00068284b70e1db45857aeee35/QW/progs/qwprogs.dat > > Either the file will need renaming using DISTFILES {} syntax, or download > it to a versioned subdirectory with DIST_SUBDIR, but that's easy enough to do.
Here's an updated tarball of the port. It now brings in qwprogs.dat separately as DISTFILES and will copy it into the share directory. I left the qwprogs.dat commit id variable in there just in case it ever changes. (It probably won't.) Thanks, Tom
mvdsv.tgz
Description: application/tar-gz
