On 2019/03/26 08:22, Alessandro DE LAURENZIS wrote: > Hello Stuart, > > On 22/03/2019 19:26, Stuart Henderson wrote: > > On 2019/03/22 16:29, Alessandro DE LAURENZIS wrote: > > > My main concern with the port is related to the license; although it is > > > clear that the software is released under the GPLv3, as confirmed by all > > > source code file headers, I'm puzzled; the README.md ends as follows: > > > > > > > ## License > > > > > > > > Copyright (c) 2019, Parallax Software, Inc. > > > > All rights reserved. > > > > > > > > No part of this document may be copied, transmitted or > > > > disclosed in any form or fashion without the express > > > > written consent of Parallax Software, Inc. > > > > > > What do you think? > > > > odd. can you ask upstream about that please? > > > > I flagged the problem upstream and they promptly amended the Copyright > notice (they use some filter to extract the open source version from the > proprietary one, see [1]).
Great! > Updated tarball attached; note that I have added: > > COMPILER = base-clang ports-gcc base-gcc > > since this is C++11 > > Also, reported the reinterpret_cast issue upstream [2] to see if it is > possible to remove the only patch we currently require (this should not > prevent to import, though). > > [1] https://github.com/abk-openroad/OpenSTA/issues/17 > > [2] https://github.com/abk-openroad/OpenSTA/issues/20 > > -- > Alessandro DE LAURENZIS > [mailto:jus...@atlantide.t28.net] > Web: http://www.atlantide.t28.net > LinkedIn: https://www.linkedin.com/in/delaurenzis/ I suspect you probably have a symlink for tclsh -> tclsh8.5. The following is needed to let it build otherwise: --- Makefile.orig Tue Mar 26 10:57:14 2019 +++ Makefile Tue Mar 26 10:56:23 2019 @@ -32,6 +32,9 @@ CONFIGURE_ARGS = -DTCL_HEADER=${MODTCL_INCDIR}/tcl.h \ NO_TEST = Yes +pre-configure: + cd ${WRKSRC}/etc && ${MODTCL_WISH_ADJ} TclEncode.tcl SwigCleanup.tcl + post-install: ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/opensta ${INSTALL_DATA} ${WRKSRC}/doc/OpenSTA.pdf ${PREFIX}/share/doc/opensta With that added, it's OK sthen@ to import.
