On Tue, May 21, 2019 at 04:45:48PM +0200, Thomas Dettbarn wrote:
> > Brian Callahan <call...@rpi.edu> hat am 21. Mai 2019 um 16:12 geschrieben:
> >
> >
> >
> >
> > On 5/21/19 10:01 AM, Leonid Bobrov wrote:
> > > http://www.dettus.net/dMagentic returns 404 error, fix this link.
> > >
> > >> PKGNAME = dMagneticx-${V}
> > > Maybe it's better to avoid upper-vase letters in PKGNAME?
> > >
> > >> REVISION = 0
> > > Remove this line.
> > >
> > >> MAINTAINER = Joe User <juser@127.0.0.1>
> > > Don't be a jerk. Remove this line or write yourself there as a maintainer.
> > >
> > >> MAKE_FLAGS = CC="${CC}" CFLAGS="${CFLAGS}"
> > > Do you need help writing a proper Makefile?
> > >
> > >> #### HELPME: Where would I put those files??
> > >> # ${INSTALL_DATA} ${WRKSRC}/dMagnetic.ini
> > >> ${PREFIX}/share/games/dMagnetic
> > >> # ${INSTALL_DATA} ${WRKSRC}/LICENSE.txt
> > >> ${PREFIX}/share/games/dMagnetic
> > >> # ${INSTALL_DATA} ${WRKSRC}/README.txt
> > >> ${PREFIX}/share/games/dMagnetic
> > > ${INSTALL_DATA_DIR} ${PREFIX}/share/dMagnetic
> > > ${INSTALL_DATA} ${WRKSRC}/dMagnetic.ini ${PREFIX}/share/dMagnetic
> > > ${INSTALL_DATA} ${WRKSRC}/LICENSE.txt ${PREFIX}/share/dMagnetic
> > > ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/dMagnetic
> > > ${INSTALL_DATA} ${WRKSRC}/README.txt ${PREFIX}/share/examples/dMagnetic
> > >
> > > I am not sure somebody would like to waste disk space to install license
> > > text.
> > >
> > > If you need help fixing your Makefile, I need read access to the
> > > snapshot of dMagnetic, not to latest release. Start using version
> > > control system, I don't care which one it will be as long as I can
> > > check out the snapshot and send a diff.
> > >
> > > And know this: the only proper maintainer of this port is you no matter
> > > how skilled you are. Don't expect somebody else to take this burden.
> > >
> >
> > Leonid: Why are you attacking a new porter who recognizes that he needs
> > help creating a port of /his own software/ and has asked for it? Please
> > don't reply to this thread any more.
> >
> > Thomas: Sorry about that. Someone (probably me) will take a look at this
> > once some free time opens up.
> >
> > ~Brian
> >
>
> Thank you Leonid. Thank you Brian.
>
>
>
> So, I worked in the suggestions from Leonid. Now compiling, installing
> and deinstalling work (on a 6.3 installation). I re-uploaded the package
> to my website. I agree, the snap-shot-thingie is not ideal, but it is the
> best I can offer you at the moment.
> The project's website is http://www.dettus.net/dMagnetic/, the port itself
> http://www.dettus.net/dMagnetic/openbsd_games_dMagnetic.tar.gz
>
>
>
> If you do have a look (which would be awesome), then please keep in mind
> that the binaries are needed for actually playing the games. The README.txt
> contains instructions as on how to get them. As does the manpage, and the
> helpscreen, and the .ini-file.
>
>
>
> Thomas
Sorry for that language of mine, I meant no offense, but anyway I caused
misunderstanding.
Thomas, I assume that dMagnetic.ini file is an example configuration, if
so, it's better to place it in ${PREFIX}/share/examples/dMagnetic/
(I see that I made a mistake by pointing README.txt file there)
Also please write a pkg/README file in your port, the ports system will
make it install as /usr/local/share/doc/pkg-readmes/dmagnetic and, after
people install a package, they'll see a message that readme is
installed, no need to install README.txt file.
Also I see that your project's Makefile has install target. I still
offer help fixing some issues in your Makefile. I can note about
CC and CFLAGS. In the source code of dMagentic write something like
this:
```
CC?= gcc
CFLAGS?= -03
CFLAGS+= -Wall
```
That way you won't need "MAKE_FLAGS =" line, because ports system should
set them via env(1). In shell that would look like this:
$ env CC=/usr/bin/clang CFLAGS="-02 -pipe" make all
If it won't set CC, then your Makefile will just default to gcc,
if it won't set CFLAGS, then your Makefile will just default to -03
Also about install target you need to know that ports system sets
PREFIX as env(1) variable, so I guess you can rename INSTALLPREFIX to
just PREFIX:
PREFIX?=/usr/local
Then in port's Makefile add this line:
FAKE_FLAGS = INSTALLMAN=${PREFIX}/man
But I am writting this for future versions of your project, so you don't
need to patch dMagentic 0.12
Also I still recommend you to use any version control system. If you are
unsure which one, most people prefer Git. Other popular VCS'es are:
Mercurial, SVN, Fossil and CVS. It's a really useful tool every
developer needs, I wish I could explain why.
