On Tue, Jun 02, 2020 at 01:18:50PM -0500, joshua stein wrote:

Hello Joshua,

> Firefox tries to execute xdg-open to parse the MIME stuff and run the
> appropriate handler for application/pdf.
[...]
> Up until Glib 2.64.2, this was done by executing gio-launch-desktop with
> xdg-open as an argument.
[...]
> This changed as of updating our Glib port to 2.64.2 a few weeks ago, and
> now Glib no longer ships with gio-launch-desktop

Aha -- I must admit, I would not have thought to look for that!

> I'm not sure how best to handle this going forward, but unveiling /bin/sh
> is not a good idea.

Agreed.

> Perhaps we include a small compiled utility with Firefox that just
> hard-codes execve("/usr/local/bin/xdg-open", ...) and then unveil that
> binary instead of gio-launch-desktop?

That's probably the most-effort option, but probably the friendliest to
users, in the sense that it restores the old behaviour?

I also wondered -- if gio-launch-desktop has disappeared in general (and
certainly we no longer have any port which includes it in a PLIST!), then
presumably Firefox on other platforms will also have to find another way of
executing xdg-open? So perhaps the problem might even go away (or, at least,
mutate into another problem) with Firefox 77.0?


Laurie

Reply via email to