Thanks for all your help and extensive patience on this Stuart! I’ll try to ensure I follow your advice on other stuff here forward. In a similar vein, a dependency is part of a local version of a library for opencv (flann)- I need to poke around a little more, but would it be advisable to try to make that into its own port and point both packages to mark it as a dependency?
On Sun, Jun 7, 2020 at 7:47 AM Stuart Henderson <s...@spacehopper.org> wrote: > I have cleaned things up a little locally but I haven't built it yet, > might send a new tarball in a bit. > > It has many internal copies of libraries which are available in other > ports, it should be changed to use those from ports instead (as is also > done in the FreeBSD port). > > On 2020/06/06 15:58, Charlie Burnett wrote: > > Hi Stuart, > > > > Is this better? I believe I covered all the bases you mentioned, thanks > for > > the help! > > > > On 2020-06-05 4:27 PM, Stuart Henderson wrote: > > > On 2020/06/05 14:44, Charlie Burnett wrote: > > > > Howdy, > > > > > > > > I'm starting to work through and add the dependencies for FreeCAD, > attached > > > > you'll find the patch adding the Visual Toolkit Library 8.2.0 to > ports. > > > > There's a version 9 available but 8.2 is what's required for FreeCAD. > > > > > > > > Development page is here: https://gitlab.kitware.com/vtk/vtk > > > > > > > > Let me know if there's anything I missed! > > > > > > > quick review, sorry for brevity: > > > > > > - send new ports as a tar.gz of the port directory, not of a diff > > > > > > - add the rcsid line at the top of the file > > > > > > # $OpenBSD$ > > > > > > - PKG_ARCH=* means "the produced package works on all arches" which > isn't > > > the case for anything with binaries > > > > > > - SHARED_LIBS version numbers should use the "major.minor" format and > start > > > from 0.0, however with the huge number of libraries it's going to be > insane > > > to analyse and figure out which individual ones need bumps in future I > think > > > you can just do it like this, so all the versions can be updated in > one go > > > > > > LIBVER = 0.0 > > > SHARED_LIBS += vtkChartsCore ${LIBVER} > > > SHARED_LIBS += vtkCommonColor ${LIBVER} > > > SHARED_LIBS += vtkCommonComputationalGeometry ${LIBVER} > > > SHARED_LIBS += vtkCommonCore ${LIBVER} > > > etc. > > > > > > - the following are set by default when cmake is used, please drop the > lines: > > > SEPARATE_BUILD > > > USE_NINJA > > > > > > - PKGNAME=${DISTNAME} is set by default and normally should be dropped, > > > though we generally prefer lowercase package names so for this I'd use > > > PKGNAME=${DISTNAME:L} to do that > > > > > > - DESCR should be word-wrapped > > > > > > - was there a particular reason for the patches that rename the > libraries? > > > e.g. > > > +- qt5_wrap_cpp(PluginMocSrcs ${PluginMocHeaders} TARGET > QVTKWidgetPlugin) > > > ++ qt5_wrap_cpp(PluginMocSrcs ${PluginMocHeaders} TARGET > QVTKWidgetPlugin-${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION}) > > > > > > doing this usually causes problems (and causes the library names to > not match > > > your SHARED_LIBS lines which results in the version numbers not being > set > > > properly). Probably want to drop those patches and rerun "make plist" > which > > > with the SHARED_LIBS changes should result in replacing > > > > > > lib/libvtkChartsCore-8.2.so.1 > > > lib/libvtkCommonColor-8.2.so.1 > > > > > > with > > > > > > @so lib/libvtkChartsCore.so.${LIBvtkChartsCore_VERSION} > > > @so lib/libvtkCommonColor.so.${LIBvtkCommonColor_VERSION} > > > > > > etc. > > > > > > There will be some other things but it will be easier to look at > > > them with the above changed. > > > > > >
