Ralf Hildebrandt:
> * Sahil Tandon <postfix-users@postfix.org>:
> > In Postfix 2.10 Snapshot 20121022, conf/post-install tests whether
> > smtpd_relay_restrictions is already set with:
> >
> > test -n "`$POSTCONF -c $config_directory -nh smtpd_relay_restrictions`"
> >
> > This evaluates to false when smtpd_relay_restrictions is explicitly set
> > to the empty value in main.cf, resulting in the parameter being
> > overriden as described in RELEASE_NOTES. This seems inconsistent with
> > my (perhaps faulty) interpretation of intended behavior. Would it make
> > more sense to revise the above test to:
> >
> > test -n "`$POSTCONF -c $config_directory -n smtpd_relay_restrictions`"
> >
> > With this, the forward compatibility shim would only trigger if
> > smtpd_relay_restrictions does not appear in an existing main.cf, while
> > explicitly empty settings of the parameter would be preserved during an
> > upgrade.
>
> I think your proposal is good. I encountered the same behaviour (I
> first set smtpd_relay_restrictions to an empty value and THEN upgraded)
OK, I have changed this.
BTW I duplicated that test from the inet_protocols compatibility
shim. That parameter is usually not set to the empty value but the
shim has the same problem.
Wietse
