On Sat, Sep 27, 2014 at 03:14:11PM -0400, Wietse Venema wrote:
> Viktor Dukhovni:
> > On Sat, Sep 27, 2014 at 02:51:37PM -0400, Wietse Venema wrote:
> >
> > > > In other respects, is the rest of the patch sound (correct and
> > > > useful)? I am not advocating that the patch be adopted, just using
> > >
> > > postconf does not suppress parameters based on string comparison.
> > > Instead, suppression is based on the origin of their definition.
> > >
> > > Making config_directory behavior different in this respect would
> > > be a mistake.
> >
> > Yes, got that, so with the string comparison eliminated, is the
> > rest of it a feature or a bug?
>
> With this patch, which is smaller than the previous version, the
> "postconf -n" command produces no "config_directory" output unless
> a "config_directory" override is given with MAIL_CONFIG, -c or -o.
>
> In my view the config_directory behavior is consistent with the
> rest of Postfix. What are you referring to with "the rest of it"?
"Rest of it" meant without the strcmp(..., DEF_CONFIG_DIR). Thus
the complete patch you're commenting on.
--
Viktor.
