Github user aweisberg commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/224#discussion_r198251878
--- Diff: src/java/org/apache/cassandra/locator/Replicas.java ---
@@ -50,6 +50,30 @@
public abstract int size();
protected abstract Collection<Replica> getUnmodifiableCollection();
+
+ public boolean equals(Object o)
--- End diff --
Because it breaks equality comparisons and hash code as they don't really
have a good definition. If you look at how java.util.Collections and Guava do
it you can't actually construct something that isn't either a set or a list. I
think it's a better approach then having some things returned that aren't
comparable to other collections (either list or set) with the same contents.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
