Github user bdeggleston commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/224#discussion_r198265430
--- Diff: src/java/org/apache/cassandra/locator/Replicas.java ---
@@ -50,6 +50,30 @@
public abstract int size();
protected abstract Collection<Replica> getUnmodifiableCollection();
+
+ public boolean equals(Object o)
--- End diff --
> If you look at how java.util.Collections and Guava do it you can't
actually construct something that isn't either a set or a list.
The objects returned by com.google.common.collect.Iterables (which these
methods are imitating) don't define equals or hashCode.
The issue here might be that I'm thinking of these objects as iterables,
and you seem to be thinking of them as collections. Maybe this is more a
naming issue?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
