Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r198305783
  
    --- Diff: src/java/org/apache/cassandra/locator/Replicas.java ---
    @@ -50,6 +50,30 @@
         public abstract int size();
         protected abstract Collection<Replica> getUnmodifiableCollection();
     
    +
    +    public boolean equals(Object o)
    --- End diff --
    
    Sure if they don't implement they implement Iterable instead of Collection 
I think it's fine for them to not be an implementation of a collection (list, 
set, multi-set).
    
    Interesting side note, java.util.AbstractQueue doesn't implement equals! 
Neither does say ArrayBlockingQueue or ArrayDeque.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to