Mmuzaf commented on code in PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#discussion_r1823047991
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##########
@@ -1333,7 +1332,7 @@ public void cacheKey(DecoratedKey key, RowIndexEntry info)
{
CachingParams caching = metadata().params.caching;
- if (!caching.cacheKeys() || keyCache == null || keyCache.getCapacity()
== 0)
+ if (!caching.cacheKeys() || keyCache == null ||
DatabaseDescriptor.getKeyCacheSizeInMiB() == 0)
Review Comment:
Similar to the comment above,`isRowCacheEnabled()` should be used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
