Mmuzaf commented on code in PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#discussion_r1823066870
##########
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:
##########
@@ -3048,19 +3049,19 @@ public boolean isEmpty()
public boolean isRowCacheEnabled()
{
- boolean retval = metadata().params.caching.cacheRows() &&
CacheService.instance.rowCache.getCapacity() > 0;
+ boolean retval = metadata().params.caching.cacheRows() &&
DatabaseDescriptor.getRowCacheSizeInMiB() > 0;
Review Comment:
I think for the row cache the correct condition is the following:
`getRowCacheClassName() =! null && conf.row_cache_size.toMebibytes() > 0`
As the row cache is pluggable we should also check the pluggable class is
not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
