Mmuzaf commented on code in PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#discussion_r1823047019
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##########
@@ -716,9 +716,8 @@ public void setupOnline()
// under normal operation we can do this at any time, but SSTR is also
used outside C* proper,
// e.g. by BulkLoader, which does not initialize the cache. As a
kludge, we set up the cache
// here when we know we're being wired into the rest of the server
infrastructure.
- InstrumentingCache<KeyCacheKey, RowIndexEntry> maybeKeyCache =
CacheService.instance.keyCache;
- if (maybeKeyCache.getCapacity() > 0)
- keyCache = maybeKeyCache;
+ if (DatabaseDescriptor.getKeyCacheSizeInMiB() > 0)
Review Comment:
I think for the sake of clarity `isRowCacheEnabled()` should be used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
