maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1831944499
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -182,8 +182,9 @@ static Set<String> asSet()
{
Set<String> valueSet = new HashSet<>();
ConfigKey[] values = values();
- for(ConfigKey key: values) {
- valueSet.add(key.getKeyName().toLowerCase());
+ for (ConfigKey key : values)
+ {
+ valueSet.add(key.toString().toLowerCase());
Review Comment:
@smiklosovic How do you suggest I do this? I was thinking of doing following,
1. get the latest trunk to my local (already done)
2. create another branch - let us say -
`CASSANDRA-18508-sensitive-jmx-ssl-config-2` from the latest trunk
3. cherry-pick the squashed commit from the branch
`CASSANDRA-18508-sensitive-jmx-ssl-config` to the above branch and change this
PR to be from the `CASSANDRA-18508-sensitive-jmx-ssl-config-2`
Let me know if there are better suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
