smiklosovic commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1832775836
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -182,8 +182,9 @@ static Set<String> asSet()
{
Set<String> valueSet = new HashSet<>();
ConfigKey[] values = values();
- for(ConfigKey key: values) {
- valueSet.add(key.getKeyName().toLowerCase());
+ for (ConfigKey key : values)
+ {
+ valueSet.add(key.toString().toLowerCase());
Review Comment:
@maulin-vasavada
https://app.circleci.com/pipelines/github/instaclustr/cassandra/4958/workflows/134abde9-5c0d-47f6-82d5-d02f9be48078
Fails on
`com.datastax.driver.core.exceptions.ServerError: An unexpected error
occurred server side on localhost/127.0.0.1:46255:
org.yaml.snakeyaml.error.YAMLException: Failed calling getter for property
'optional' on class org.apache.cassandra.config.EncryptionOptions`
Suppressed: java.lang.RuntimeException: Error calling get() on
jmx_encryption_options.optional of class java.lang.Boolean
at
org.apache.cassandra.config.Properties$AndThen.get(Properties.java:191)
... 28 common frames omitted
Caused by: java.lang.IllegalStateException: EncryptionOptions.applyConfig
must be called first
at
org.apache.cassandra.config.EncryptionOptions.ensureConfigApplied(EncryptionOptions.java:368)
at
org.apache.cassandra.config.EncryptionOptions.getOptional(EncryptionOptions.java:413)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.apache.cassandra.config.DefaultLoader$MethodPropertyPlus.get(DefaultLoader.java:107)
... 29 common frames omitted
```
✕ j17_unit_tests 15m 17s
org.apache.cassandra.db.virtual.SettingsTableTest
testTransparentEncryptionOptionsOverride
org.apache.cassandra.db.virtual.SettingsTableTest testArray
org.apache.cassandra.db.virtual.SettingsTableTest testSelectAll
org.apache.cassandra.db.virtual.SettingsTableTest testSelectEmpty
org.apache.cassandra.db.virtual.SettingsTableTest testAuditOverride
org.apache.cassandra.db.virtual.SettingsTableTest testSelectOverride
org.apache.cassandra.db.virtual.SettingsTableTest testSelectPartition
org.apache.cassandra.db.virtual.SettingsTableTest
testEncryptionOverride
org.apache.cassandra.config.PropertiesTest backAndForth
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
