maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1831960574
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -182,8 +182,9 @@ static Set<String> asSet()
{
Set<String> valueSet = new HashSet<>();
ConfigKey[] values = values();
- for(ConfigKey key: values) {
- valueSet.add(key.getKeyName().toLowerCase());
+ for (ConfigKey key : values)
+ {
+ valueSet.add(key.toString().toLowerCase());
Review Comment:
I managed to find a way out-
1. I got the latest trunk locally
2. I created a temp branch out of it
3. cherry-picked commit(s) from the
`CASSANDRA-18508-sensitive-jmx-ssl-config` branch to the temp branch
4. resolved any conflicts in the `EncryptionOptions.java`
5. force renamed the temp branch `git branch -f -m
CASSANDRA-18508-sensitive-jmx-ssl-config`
6. fetched from myfork/`CASSANDRA-18508-sensitive-jmx-ssl-config` branch and
resolved the same conflict
7. pushed the local branch to myfork to update this PR
This seem to have worked. Please review and we can move to Doug for more
reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
