dcapwell commented on code in PR #3662:
URL: https://github.com/apache/cassandra/pull/3662#discussion_r1837069057
##########
src/java/org/apache/cassandra/config/AccordSpec.java:
##########
@@ -38,6 +38,20 @@ public class AccordSpec
public volatile boolean enable_journal_compaction = true;
+ /**
+ * Enables the virtual Accord debug keyspace with tables
+ * that expose internal state to aid the developers working
+ * on Accord implementation.
+ * <p/>
+ * These tables can and will change and/or go away at any point,
+ * including in a minor release, and are NOT to be relied on for anything.
+ * <p/>
+ * Only enable this keyspace if you are working on Accord and
+ * need to debug an issue with Accord implementation, or if an Accord
+ * developer asked you to.
+ */
+ public boolean enable_virtual_debug_keyspace = false;
Review Comment:
this documentation is not enough for saying the tables are not exposed to
the public API.
See `Re: [EXTERNAL] Re: [DISCUSS] Adding experimental vtables and rules
around them` for the dev thread about this topic.
To unblock you I am fine withs something like
`enable_unsupported_virtual_tables` as the name tells you they are
`unsupported`, but I am a hard -1 on merging Accord to trunk with this topic
not dealt with. As a project we need to define a way to have experimental (aka
unsupported) tables, and until that is done Accord can not merge to trunk as it
is the first to define such tables...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
