belliottsmith commented on code in PR #3662:
URL: https://github.com/apache/cassandra/pull/3662#discussion_r1838533132
##########
src/java/org/apache/cassandra/config/AccordSpec.java:
##########
@@ -38,6 +38,20 @@ public class AccordSpec
public volatile boolean enable_journal_compaction = true;
+ /**
+ * Enables the virtual Accord debug keyspace with tables
+ * that expose internal state to aid the developers working
+ * on Accord implementation.
+ * <p/>
+ * These tables can and will change and/or go away at any point,
+ * including in a minor release, and are NOT to be relied on for anything.
+ * <p/>
+ * Only enable this keyspace if you are working on Accord and
+ * need to debug an issue with Accord implementation, or if an Accord
+ * developer asked you to.
+ */
+ public boolean enable_virtual_debug_keyspace = false;
Review Comment:
I was previously an operator, and manually using introspection views on e.g.
SQL Server was a perfectly normal activity, and I did not use scripts to access
this information. By "Consumable by applications" I meant "API" (the A means
application)
I'm obviously not _opposed_ to folk using scripts, just so long as they
accept the possibility that their scripts may need tweaking when they go to use
them, because we don't promise not to break them. If the scripts are just
labour saving devices that the operator understands, this shouldn't be overly
onerous, or destroy the value proposition.
The alternative in my view is either _not providing these views_, or
providing ones with massively reduced information. One option might be to have
restricted versions of each view, and a config flag that enriches the tables
with more information, and makes more tables available. But I would prefer to
explore that closer to release of 5.1, as in the meantime many of these tables
will change anyway.
I'm agnostic regarding naming of any flag, and also perfectly supportive of
migrating this to some endorsed "unstable API" mechanism as and when it becomes
available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
