belliottsmith commented on code in PR #3662:
URL: https://github.com/apache/cassandra/pull/3662#discussion_r1837122521
##########
src/java/org/apache/cassandra/config/AccordSpec.java:
##########
@@ -38,6 +38,20 @@ public class AccordSpec
public volatile boolean enable_journal_compaction = true;
+ /**
+ * Enables the virtual Accord debug keyspace with tables
+ * that expose internal state to aid the developers working
+ * on Accord implementation.
+ * <p/>
+ * These tables can and will change and/or go away at any point,
+ * including in a minor release, and are NOT to be relied on for anything.
+ * <p/>
+ * Only enable this keyspace if you are working on Accord and
+ * need to debug an issue with Accord implementation, or if an Accord
+ * developer asked you to.
+ */
+ public boolean enable_virtual_debug_keyspace = false;
Review Comment:
To to be as explicit as possible: these tables are intended for human
consumption only. To my knowledge it is not project policy that virtual tables
must be consumable by applications, but even if you take that they are then
flagging them off resolves any concern. This is all we mean by API-unstable.
Really we mean "NOT AN API, ONLY AN HMI". Applications that take a dependency
on them can expect to break without warning, but human operators can generally
expect to interpret them if they understand the relevant internals.
We will never provide an API for viewing _implementation details_ while I
have a say, as it would prevent reasonable development. But, it is helpful to
expose these details to operators for human interpretation of the cluster state
_only_.
I am aware of no project policy that would be in conflict with merge. So, if
you are opposed to merging CEP-15 once this has merged, please decide what you
require to proceed and take it to the list for discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
