joao-r-reis commented on code in PR #1793:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1793#discussion_r1850752379
##########
query_executor.go:
##########
@@ -83,7 +83,28 @@ func (q *queryExecutor) speculate(ctx context.Context, qry
ExecutableQuery, sp S
}
func (q *queryExecutor) executeQuery(qry ExecutableQuery) (*Iter, error) {
- hostIter := q.policy.Pick(qry)
+ type hostGetter interface {
Review Comment:
How about adding a private interface like:
```
type cqlQuery interface {
ExecutableQuery
getHost() *HostInfo
}
```
And make gocql internal code use `cqlQuery` (name subject to change?)
instead of `ExecutableQuery` so that we don't have to worry about breaking the
public `ExecutableQuery` interface when we add new functions to `Query` or
`Batch`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
