joao-r-reis commented on code in PR #1793:
URL: 
https://github.com/apache/cassandra-gocql-driver/pull/1793#discussion_r1850756067


##########
query_executor.go:
##########
@@ -83,7 +83,28 @@ func (q *queryExecutor) speculate(ctx context.Context, qry 
ExecutableQuery, sp S
 }
 
 func (q *queryExecutor) executeQuery(qry ExecutableQuery) (*Iter, error) {
-       hostIter := q.policy.Pick(qry)
+       type hostGetter interface {

Review Comment:
   Alternatively, we could just add new functions to `ExecutableQuery` because 
there's no place where a user can provide a custom implementation of 
`ExecutableQuery` to the driver is there? If the driver API doesn't expose any 
function that receives an object of type `ExecutableQuery` then we should be 
fine changing this interface since there's no real use case where a user might 
implement it on their application.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to