worryg0d commented on code in PR #1793:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1793#discussion_r1850804970
##########
query_executor.go:
##########
@@ -83,7 +83,28 @@ func (q *queryExecutor) speculate(ctx context.Context, qry
ExecutableQuery, sp S
}
func (q *queryExecutor) executeQuery(qry ExecutableQuery) (*Iter, error) {
- hostIter := q.policy.Pick(qry)
+ type hostGetter interface {
Review Comment:
But it still remains untestable because `ExecutableQuery` already has some
private methods. But this is out of the scope of this PR. Ok, I'm going to
update implementation with this one.
One thing came in mind, this PR doesn't provide this API for `Batch`. Should
I add this API to `Batch` to be consistent with the `Query`? This PR focuses on
virtual tables, and main purpose of Batch is data modification, so it actually
cannot be used with virtual tables...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
