dcapwell commented on code in PR #3731:
URL: https://github.com/apache/cassandra/pull/3731#discussion_r1876733154
##########
src/java/org/apache/cassandra/db/filter/RowFilter.java:
##########
@@ -705,7 +705,7 @@ public boolean isSatisfiedBy(TableMetadata metadata,
DecoratedKey partitionKey,
if (column.type.isCounter())
{
ByteBuffer foundValue = getValue(metadata, partitionKey,
row);
- if (foundValue == null)
+ if (foundValue == null || foundValue.remaining() == 0)
Review Comment:
looked into it... we do `org.apache.cassandra.cql3.terms.Constants.Deleter`
when we delete a column. This is defined as
```
builder.addCell(BufferCell.tombstone(column, timestamp, nowInSec, path));
```
which is
```
public static BufferCell tombstone(ColumnMetadata column, long timestamp,
long nowInSec, CellPath path)
{
return new BufferCell(column, timestamp, NO_TTL, nowInSec,
ByteBufferUtil.EMPTY_BYTE_BUFFER, path);
}
```
so delete column is defined as write empty bytes... that explains the empty
bytes at least
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
