maedhroz commented on code in PR #3731:
URL: https://github.com/apache/cassandra/pull/3731#discussion_r1904712793
##########
src/java/org/apache/cassandra/db/filter/RowFilter.java:
##########
@@ -529,7 +529,7 @@ protected ByteBuffer getValue(TableMetadata metadata,
DecoratedKey partitionKey,
return row.clustering().bufferAt(column.position());
default:
Cell<?> cell = row.getCell(column);
- return cell == null ? null : cell.buffer();
+ return Cell.getValidCellBuffer(cell, nowInSec);
Review Comment:
I think we should just replace this w/ `return cell == null ||
cell.isTombstone() || !cell.isLive(nowInSec) ? null : cell.buffer();` and
remove `Cell.getValidCellBuffer()`. What we're doing here is IMO specific to
filtering, and at the very least the buffer in a tombstoned cell isn't
"invalid"...it's just the buffer value when the cell is tombstoned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
