dcapwell commented on code in PR #3731:
URL: https://github.com/apache/cassandra/pull/3731#discussion_r1896171018
##########
src/java/org/apache/cassandra/db/filter/RowFilter.java:
##########
@@ -529,7 +530,7 @@ protected ByteBuffer getValue(TableMetadata metadata,
DecoratedKey partitionKey,
return row.clustering().bufferAt(column.position());
default:
Cell<?> cell = row.getCell(column);
- return cell == null ? null : cell.buffer();
+ return Cell.getValidCellBuffer(cell, nowInSeconds());
Review Comment:
`org.apache.cassandra.db.filter.RowFilter#filter(org.apache.cassandra.schema.TableMetadata,
long)`
we are passed in a `nowInSeconds`! It looks like we can refactor the caller
to pass this value in, that way we don't call `nowInSeconds` for every cell
(this can become a problem)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
