dcapwell commented on code in PR #3743:
URL: https://github.com/apache/cassandra/pull/3743#discussion_r1884694660
##########
test/unit/org/apache/cassandra/dht/IPartitionerTest.java:
##########
@@ -93,7 +94,9 @@ private boolean isTestType(Class<? extends IPartitioner>
klass)
@Test
public void byteCompareSerde()
{
-
qt().forAll(AccordGenerators.fromQT(CassandraGenerators.token())).check(token
-> {
+ // make sure to use simplify as local partitioner can have a type that
could generate data too large causing this test to be flakey
+ Gen<Token> qt = CassandraGenerators.partitioners().flatMap(p ->
CassandraGenerators.token(CassandraGenerators.simplify(p)));
Review Comment:
flakey test during my first CI run. `LocalPartitioner` can have very
complex type, which leads to tokens too large causing the test to be flakey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
