dcapwell commented on code in PR #3743:
URL: https://github.com/apache/cassandra/pull/3743#discussion_r1887724012
##########
src/java/org/apache/cassandra/journal/Journal.java:
##########
@@ -939,6 +985,8 @@ private StaticSegmentIterator()
StaticSegment.KeyOrderReader<K> reader =
staticSegment.keyOrderReader();
if (reader.advance())
this.readers.add(reader);
+ else
+ reader.close();
Review Comment:
file leak found in testing
##########
src/java/org/apache/cassandra/journal/Journal.java:
##########
@@ -962,6 +1010,8 @@ public void readAllForKey(K key, RecordConsumer<K> reader)
reader.accept(next.descriptor.timestamp, next.offset,
next.key(), next.record(), next.hosts(), next.descriptor.userVersion);
if (next.advance())
readers.add(next);
+ else
+ next.close();
Review Comment:
file leak found in testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
