Jollyplum commented on code in PR #3742:
URL: https://github.com/apache/cassandra/pull/3742#discussion_r1901369956
##########
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java:
##########
@@ -175,6 +176,16 @@ private Map<String, Object>
convertStatsTableToMap(StatsTable table)
mpTable.put("top_tombstone_partitions", table.topTombstonePartitions);
if (locationCheck)
mpTable.put("sstables_in_correct_location",
table.isInCorrectLocation);
+
Review Comment:
It might overcomplicate things somewhat but I did have the thought that it
may be worth only adding these metrics if SAI is actually in use on the table
in question, added a comment to that effect also in JIRA:
https://issues.apache.org/jira/browse/CASSANDRA-20026?focusedCommentId=17909432&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17909432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
