Mmuzaf commented on code in PR #3742:
URL: https://github.com/apache/cassandra/pull/3742#discussion_r1913646825
##########
src/java/org/apache/cassandra/tools/nodetool/stats/StatsTableComparator.java:
##########
@@ -66,7 +66,10 @@ public class StatsTableComparator implements
Comparator<StatsTable>
"space_used_by_snapshots_total", "space_used_live",
"space_used_total",
"sstable_compression_ratio", "sstable_count",
"table_name",
"write_latency", "writes", "max_sstable_size",
-
"local_read_write_ratio", "twcs_max_duration"};
+
"local_read_write_ratio", "twcs_max_duration", "sai_local_query_latency",
Review Comment:
"local_read_latency_ms", "local_write_latency_ms" are with the "ms" postfix,
but here we use it without any postfix. Any particular reason for this? It
feels like the naming should be preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]