Mmuzaf commented on code in PR #3742:
URL: https://github.com/apache/cassandra/pull/3742#discussion_r1913650160
##########
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsPrinter.java:
##########
@@ -168,6 +169,19 @@ protected void printStatsTable(StatsTable table, String
tableDisplayName, String
for (Map.Entry<String, Long> tombstonecnt :
table.topTombstonePartitions.entrySet())
out.printf(indent + " %-" + maxWidth + "s %s%n",
tombstonecnt.getKey(), tombstonecnt.getValue());
}
+
+ if (!SchemaConstants.isSystemKeyspace(table.keyspaceName) &&
table.saiTotalIndexCount > 0)
+ {
+ out.println(indent + "SAI local query latency (mean): " +
FBUtilities.prettyPrintLatency(table.saiQueryLatencyMs));
+ out.println(indent + "SAI post-filtering latency (mean): " +
FBUtilities.prettyPrintLatency(table.saiPostFilteringReadLatencyms));
+ out.println(indent + "SAI space used (bytes): " +
table.saiDiskUsedBytes);
+ out.println(indent + "SAI sstable indexes hit per query
(mean): " + table.saiSSTableIndexesHit);
+ out.println(indent + "SAI index segments hit per query (mean):
" + table.saiIndexSegmentsHit);
+ out.println(indent + "SAI rows filtered per query (mean): " +
table.saiRowsFiltered);
+ out.println(indent + "SAI local query timeouts: " +
table.saiTotalQueryTimeouts);
+ out.println(indent + "SAI queryable/total indexes: " +
table.saiTotalQueryableIndexRatio);
Review Comment:
as far as I can see the ration is inverted from the line where it's set:
`String.format("%d/%d", statsTable.saiTotalIndexCount,
saiTotalQueryableIndexCount);`
Should be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
