tengu-alt commented on code in PR #1858:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1858#discussion_r1941013795
##########
control.go:
##########
@@ -172,7 +176,12 @@ func hostInfo(addr string, defaultPort int) ([]*HostInfo,
error) {
}
for _, ip := range ips {
- hosts = append(hosts, &HostInfo{hostname: host, connectAddress:
ip, port: port})
+ h, err := newHostInfo(ip, port)
Review Comment:
Souns good, as I understand we need to keep the places when we create
`HostInfo` using the `newHostInfo()` as it is now(in the PR), and wrap the
`hostInfoFromMap` where `HostInfo` being provided as raw struct. Is it correct?
And, of course apply the suggestions above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
