jameshartig commented on code in PR #1858:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1858#discussion_r1945887861
##########
host_source.go:
##########
@@ -224,18 +234,20 @@ func (h *HostInfo) ConnectAddress() net.IP {
h.mu.RLock()
defer h.mu.RUnlock()
- if addr, _ := h.connectAddressLocked(); validIpAddr(addr) {
- return addr
- }
- panic(fmt.Sprintf("no valid connect address for host: %v. Is your
cluster configured correctly?", h))
+ addr, _ := h.connectAddressLocked()
+ return addr
}
-func (h *HostInfo) SetConnectAddress(address net.IP) *HostInfo {
- // TODO(zariel): should this not be exported?
+func (h *HostInfo) SetConnectAddress(address net.IP) (*HostInfo, error) {
Review Comment:
Typically I'd like to go through a version or so of it being deprecated but
since we're about to cut a major release I think it makes sense to remove it
and we can always add it back if there's a reason to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
