tengu-alt commented on code in PR #1858:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1858#discussion_r1944467350
##########
host_source.go:
##########
@@ -186,19 +198,17 @@ func validIpAddr(addr net.IP) bool {
}
func (h *HostInfo) connectAddressLocked() (net.IP, string) {
- if validIpAddr(h.connectAddress) {
+ if h.connectAddress != nil {
return h.connectAddress, "connect_address"
- } else if validIpAddr(h.rpcAddress) {
+ } else if h.rpcAddress != nil {
return h.rpcAddress, "rpc_adress"
- } else if validIpAddr(h.preferredIP) {
- // where does perferred_ip get set?
+ } else if h.preferredIP != nil {
return h.preferredIP, "preferred_ip"
- } else if validIpAddr(h.broadcastAddress) {
+ } else if h.broadcastAddress != nil {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
