belliottsmith commented on code in PR #168:
URL: https://github.com/apache/cassandra-accord/pull/168#discussion_r1954107627
##########
accord-core/src/main/java/accord/coordinate/ExecuteTxn.java:
##########
@@ -192,11 +198,25 @@ protected Action process(Id from, ReadReply reply)
CommitOrReadNack nack = (CommitOrReadNack) reply;
switch (nack)
{
- default: throw new IllegalStateException();
+ default: throw new UnhandledEnum(nack);
+ case Waiting:
+ if (from.id != node.id().id)
+ throw new UnhandledEnum(nack);
Review Comment:
It means we aren't expecting this reply from anyone but ourselves, and so we
don't know how to handle the reply. I am happy to use another exception, but I
don't think node id mismatch is correct, it's that the enum shouldn't have come
from another node, and it did, so we don't know what to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
