ifesdjeen commented on code in PR #168:
URL: https://github.com/apache/cassandra-accord/pull/168#discussion_r1954203233
##########
accord-core/src/main/java/accord/coordinate/ExecuteTxn.java:
##########
@@ -192,11 +198,25 @@ protected Action process(Id from, ReadReply reply)
CommitOrReadNack nack = (CommitOrReadNack) reply;
switch (nack)
{
- default: throw new IllegalStateException();
+ default: throw new UnhandledEnum(nack);
+ case Waiting:
+ if (from.id != node.id().id)
+ throw new UnhandledEnum(nack);
Review Comment:
I am mostly concerned that in case codebase diverges from the deployed
version we might mistake this unhandled enum from the one on L201. I don't mind
throwing here, just maybe assertion error, or some other exception? I don't
mind swallowing the response in this case, either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
