belliottsmith commented on code in PR #168:
URL: https://github.com/apache/cassandra-accord/pull/168#discussion_r1957105866
##########
accord-core/src/main/java/accord/coordinate/CollectLatestDeps.java:
##########
@@ -95,10 +109,15 @@ public void onFailure(Id from, Throwable failure)
if (isDone)
return;
+ if (failure != null)
+ this.failure = FailureAccumulator.append(this.failure, failure);
+
if (tracker.recordFailure(from) == Failed)
{
isDone = true;
- callback.accept(null, new Timeout(txnId, route.homeKey()));
+ if (this.failure == null)
Review Comment:
I've just updated to Exhausted for now. There's already TODOs littered about
the place to look at our exception handling, but I'll add another here as well
to be sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
