frankgh commented on code in PR #3905:
URL: https://github.com/apache/cassandra/pull/3905#discussion_r1958851585
##########
src/java/org/apache/cassandra/db/virtual/VirtualKeyspaceRegistry.java:
##########
@@ -73,6 +76,11 @@ public TableMetadata getTableMetadataNullable(TableId id)
return null != table ? table.metadata() : null;
}
+ public ImmutableSet<String> getKeyspaces()
+ {
+ return ImmutableSet.copyOf(virtualKeyspaces.keySet());
+ }
+
Review Comment:
this is not needed, as we can get it from
`SchemaConstants.isVirtualSystemKeyspace(String)`.
##########
src/java/org/apache/cassandra/auth/DataResource.java:
##########
@@ -249,7 +250,8 @@ public boolean exists()
return true;
case KEYSPACE:
case ALL_TABLES:
- return Schema.instance.getKeyspaces().contains(keyspace);
+ return Schema.instance.getKeyspaces().contains(keyspace) ||
+
VirtualKeyspaceRegistry.instance.getKeyspaces().contains(keyspace);
Review Comment:
can we use `SchemaConstants.isVirtualSystemKeyspace(keyspace)` instead?
```suggestion
SchemaConstants.isVirtualSystemKeyspace(keyspace);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
