frankgh commented on code in PR #3905:
URL: https://github.com/apache/cassandra/pull/3905#discussion_r1960160405
##########
src/java/org/apache/cassandra/auth/DataResource.java:
##########
@@ -249,7 +250,8 @@ public boolean exists()
return true;
case KEYSPACE:
case ALL_TABLES:
- return Schema.instance.getKeyspaces().contains(keyspace);
+ return Schema.instance.getKeyspaces().contains(keyspace) ||
+
VirtualKeyspaceRegistry.instance.getKeyspaces().contains(keyspace);
Review Comment:
I spoke offline with @Maxwell-Guo and discussed about whether
`SchemaConstants.isVirtualSystemKeyspace` is a good fit or not. While
`VirtualKeyspaceRegistry` offers a dynamic approach to checking whether a
virtual keyspace exists or not, `SchemaConstants.isVirtualSystemKeyspace` has
statically defined virtual keyspace names. Is there a scenario where these two
diverge? And if they do not diverge can we use
`SchemaConstants.isVirtualSystemKeyspace` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
