frankgh commented on code in PR #3905:
URL: https://github.com/apache/cassandra/pull/3905#discussion_r1960163808
##########
src/java/org/apache/cassandra/db/virtual/VirtualKeyspaceRegistry.java:
##########
@@ -73,6 +76,11 @@ public TableMetadata getTableMetadataNullable(TableId id)
return null != table ? table.metadata() : null;
}
+ public ImmutableSet<String> getKeyspaces()
Review Comment:
Yeah, I think the `exists(keyspace)` semantics makes more sense. I'd prefer
if we avoid having to return a copy of the keyspace name set just for the
purpose of checking its existence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
