jameshartig commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1959996094
##########
.github/workflows/main.yml:
##########
@@ -101,7 +101,7 @@ jobs:
ccm status
ccm node1 nodetool status
- args="-gocql.timeout=60s -runssl -proto=4 -rf=3 -clusterSize=3
-autowait=2000ms -compressor=${{ matrix.compressor }} -gocql.cversion=$VERSION
-cluster=$(ccm liveset) ./..."
+ args="-gocql.timeout=60s -runssl -proto=5 -rf=3 -clusterSize=3
-autowait=2000ms -compressor=${{ matrix.compressor }} -gocql.cversion=$VERSION
-cluster=$(ccm liveset) ./..."
Review Comment:
Should we be updating the matrix to test protocol version 4 and 5? Same
thing about the next one too.
##########
.github/workflows/main.yml:
##########
@@ -37,7 +37,7 @@ jobs:
go: [ '1.22', '1.23' ]
cassandra_version: [ '4.0.13', '4.1.6' ]
auth: [ "false" ]
- compressor: [ "snappy" ]
+ compressor: [ "lz4" ]
Review Comment:
Should we be testing snappy and lz4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
